ref(buffer): Move project prefetch into push #5521
Merged
+28
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
approved these changes
Jan 8, 2026
Member
Dav1dde
left a comment
Dav1dde
left a comment
There was a problem hiding this comment.
Overall an improvement one less implicit requirement, it will however increase the load on the project cache (I assume 2x) since now there are 2 fetch calls happening:
- in the "fast path" when accessing rate limits
- another fetch from the buffer
Should observe usage and if it is a problem we can think of a solution which only conditionally triggers a fetch.
Member
Author
👍 will roll out carefully, if this causes problems we can always revert. |
Member
|
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spooler V1 has been removed, so we can act upon this follow-up.